[Webkit-unassigned] [Bug 127576] WebKit2GTK - WebKitWebProcess assertion fails when dragging and dropping a file into the view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127576





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-08-11 00:49:17 PST ---
(From update of attachment 236350)
View in context: https://bugs.webkit.org/attachment.cgi?id=236350&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1369
> +    if (dragData.containsURL(nullptr))
> +        m_process->assumeReadAccessToBaseURL(dragData.asURL(nullptr));

This is correct, but I would do something like this:

String url = dragData.asURL(nullptr);
if (!url.isEmpty())
    m_process->assumeReadAccessToBaseURL(url);

To avoid building the string URL twice, since containsURL() is indeed !asURL().isEmpty().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.