[Webkit-unassigned] [Bug 135766] [WinCairo] Enable GStreamer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135766





--- Comment #4 from peavo at outlook.com  2014-08-09 03:47:31 PST ---
(In reply to comment #2)
> (From update of attachment 236306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236306&action=review
> 

Thanks for reviewing :)

> I would r+ most of this, except Platform.h.  I left the GStreamer property sheets in to not remove the future possibility of using GStreamer.
> 
> > Source/WTF/wtf/Platform.h:861
> > +#define WTF_USE_GLIB 1
> 

This seems to be needed, I get compile errors without it.

> I think people want glib to not be a dependency.  See the discussion after https://lists.webkit.org/pipermail/webkit-dev/2014-April/026478.html
> I'm ok with putting the rest of these changes in to make your work easier, but I do not want to switch the default build to GStreamer unless it works with seeking and loading correctly.  
> https://bugs.webkit.org/show_bug.cgi?id=127376 (which I'm not working on any more)

I believe this was caused by a bug in the Curl disc cache implementation, which I think is fixed now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.