[Webkit-unassigned] [Bug 135476] Implement long mouse press over links. Part of 135257 - Add long mouse press gesture.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135476





--- Comment #13 from Peyton Randolph <prandolph at apple.com>  2014-08-08 16:15:01 PST ---
(In reply to comment #12)
> (From update of attachment 236311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236311&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:136
> > +const std::chrono::milliseconds LongMousePressRecognitionDelay = 500_ms;
> > +const int MaximumLongMousePressDragDistance = 5; // in points.
> 
> Lowercase leading letters was actually correct, the things around here are wrong :D

Ah, the constants above lie. Fixed.
> 
> > Source/WebCore/page/EventHandler.h:384
> > +    bool mouseMovementExceedsThreshold(const FloatPoint&, const int pointsThreshold) const;
> 
> Sounds good to me!
> 
> Don't think you need the 'const' on the int parameter (some would even say const reference is overkill for FloatPoint, but I will leave that be).

Removed the const int.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.