[Webkit-unassigned] [Bug 135766] [WinCairo] Enable GStreamer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135766


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236306|review?                     |review-
               Flag|                            |




--- Comment #2 from Alex Christensen <achristensen at apple.com>  2014-08-08 15:49:05 PST ---
(From update of attachment 236306)
View in context: https://bugs.webkit.org/attachment.cgi?id=236306&action=review

I would r+ most of this, except Platform.h.  I left the GStreamer property sheets in to not remove the future possibility of using GStreamer.

> Source/WTF/wtf/Platform.h:861
> +#define WTF_USE_GLIB 1

I think people want glib to not be a dependency.  See the discussion after https://lists.webkit.org/pipermail/webkit-dev/2014-April/026478.html
I'm ok with putting the rest of these changes in to make your work easier, but I do not want to switch the default build to GStreamer unless it works with seeking and loading correctly.  
https://bugs.webkit.org/show_bug.cgi?id=127376 (which I'm not working on any more)

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:134
> +    <Import Project="..\..\..\WebKitLibraries\win\tools\vsprops\GStreamer32.props" />

Let's import GStreamerCommon.props here, too.  It's not needed, but we might want to do global changes later without wondering why WebCore is not changing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.