[Webkit-unassigned] [Bug 135734] make clean does not work in OpenSource, fails in WebKitLibraries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 8 11:46:40 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #236241|commit-queue-               |commit-queue+
               Flag|                            |

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2014-08-08 11:46:50 PST ---
(From update of attachment 236241)
View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

>> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
>> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;
> I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.
> To put another way, I'm not sure if "system() == 0" will work on Windows.

The rest of this file uses this idiom. Spoke on IRC lets land as is.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list