[Webkit-unassigned] [Bug 135734] make clean does not work in OpenSource, fails in WebKitLibraries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135734


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236241|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2014-08-08 11:24:32 PST ---
(From update of attachment 236241)
View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review

r=me

> Tools/Scripts/copy-webkitlibraries-to-product-directory:311
> +    (system("rm", "-rf", "$productDir/usr/local/include/WebKitSystemInterface.h") == 0) or die;
> +    (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die;

I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows.

To put another way, I'm not sure if "system() == 0" will work on Windows.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.