[Webkit-unassigned] [Bug 133317] [GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133317


Eduardo Lima Mitev <elima at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |133316




--- Comment #9 from Eduardo Lima Mitev <elima at igalia.com>  2014-08-08 03:02:15 PST ---
(In reply to comment #8)
> 
> It doesn't look like  ENABLE_SUBTLE_CRYPTO listed in WebKitFeatures.cmake yet or cmakeconfig.h.cmake yet?
> 

Right, ENABLE_SUBTLE_CRYPTO is added in a previous patch of this serie, for bug 133316, which is also pending review.

> > Source/WebCore/PlatformGTK.cmake:727
> > +if (ENABLE_SUBTLE_CRYPTO)
> > +    list(APPEND WebCore_INCLUDE_DIRECTORIES
> > +        ${GNUTLS_INCLUDE_DIRS}
> > +    )
> > +    list(APPEND WebCore_LIBRARIES
> > +        ${GNUTLS_LIBRARIES}
> > +    )
> 
> You don't need to make this conditional. If you don't look for the package these will be empty.

Ok, though the conditional is also introduced in patch for bug 133316. Perhaps I should not have separated this patch from the other.

To avoid these issues, I'm making this bug depend on bug 133316. After that is fixed I will update this patch accordingly.

Thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.