[Webkit-unassigned] [Bug 135732] New: Web Inspector: run-webkit-tests --debug loads inspector resources from the Release bundle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135732

           Summary: Web Inspector: run-webkit-tests --debug loads
                    inspector resources from the Release bundle
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: burg at cs.washington.edu
                CC: timothy at apple.com, ddkilzer at webkit.org,
                    joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com,
                    graouts at webkit.org, mattbaker at apple.com


This may be the cause of many debug test failures, if it's not just my machine acting up.

To reproduce (both WK1 and WK2):

1. Run LayoutTests/inspector/test-harness-trivially-works.html in Release.
2. Add some frivolous logging to the test.
3. Rebuild only the release build.
4. The logging appears when running tests for both debug and release builds.


The relevant code for the WK2 path is in WebInspectorProxy.mm:

String WebInspectorProxy::inspectorTestPageURL() const
{
    // Call the soft link framework function to dlopen it, then [NSBundle bundleWithIdentifier:] will work.
    WebInspectorUILibrary();

    NSString *path = [[NSBundle bundleWithIdentifier:@"com.apple.WebInspectorUI"] pathForResource:@"Test" ofType:@"html"];

    // We might not have a Test.html in Production builds.
    if (!path)
        return String();

    return [[NSURL fileURLWithPath:path] absoluteString];
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.