[Webkit-unassigned] [Bug 135560] [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135560


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #7 from Ryuan Choi <ryuan.choi at samsung.com>  2014-08-06 17:22:23 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > > USE(TILED_BACKING_STORE) is still being used in source code. So, I'm not sure whether we can remove this here.
> > > 
> > > If we leave it in the code, the build will fail in case of minimal build. None of the other ports use it, so it's safe to remove it.
> > 
> > If so, you can just change isEfl() with 0. Are you sure whether other ports never enable it again ?
> 
> Let's see all options one by one:
> - default => isEfl() : It means it is enabled on EFL by default, but 
>   --minimal option would disable this mandatory feature. It isn't good.
> - default => 0 : It means it would be disabled always on EFL - on minimal
>   and on normal build too. It isn't good.
> - Deleting it from FeatureList.pm would cause problem if we would like
>   to make TILED_BACKING_STORE optional. But it isn't optional at all.
>   It is mandatory on EFL and not used / not work on other ports.

Hi,
If I am right, TILED_BACKING_STORE can't be an optional nowadays because it's meaningless without Coordinated Graphics.
And if other port want to use it, it can be used like other port specific features, WTF_USE_SOUP and WTF_USE_CROSS_PLATFORM_CONTEXT_MENUS.

So, removing it from FeatureList.pm is fine to me.

FYI,
If other port want to use TILED_BACKING_STORE, there are only two options.
(1) use Coordinated Graphics.
(2) implement missing parts such as TiledBackingStoreBackend, implementation class of Tile and painting path for the pure TiledBackingStore.

I roughly listed missing parts about option (2), but it's to use TiledBackingStore on the WebKit1.
If someone want to use it on the WebKit2, it require much more modules.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.