[Webkit-unassigned] [Bug 134301] Implement parsing for CSS scroll snap points

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 6 15:21:21 PDT 2014


--- Comment #58 from Tim Horton <thorton at apple.com>  2014-08-06 15:21:29 PST ---
(In reply to comment #56)
> (From update of attachment 235954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235954&action=review
> >> LayoutTests/platform/mac/css3/scroll-snap/scroll-snap-property-computed-style.html:4
> >> +<script src="../../../../resources/js-test-pre.js"></script>
> > 
> > Is there a reason these tests are in platform/mac?
> > 
> > Can't we make the test content platform neutral?
> So far, the CSS_SCROLL_SNAP feature flag is only turned on for platform Mac (it will be on for iOS in the near future as well) so this test is specific to mac wk1 and wk2.

But it's not specific to Mac, just only enabled there. You should put the tests in generic directories and skip them on the platforms that don't implement this feature yet.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list