[Webkit-unassigned] [Bug 135565] [JSC] Build fix for FTL on EFL after ftlopt merge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135565


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236097|review?                     |review-
               Flag|                            |




--- Comment #6 from Mark Lam <mark.lam at apple.com>  2014-08-06 07:15:59 PST ---
(From update of attachment 236097)
View in context: https://bugs.webkit.org/attachment.cgi?id=236097&action=review

Also please rebase to ToT so that it’ll be easier to review this in context.  Thanks.

> Source/WTF/wtf/Platform.h:740
> +#if PLATFORM(EFL)
> +#define ENABLE_FTL_NATIVE_CALL_INLINING 0
> +#else
> +#define ENABLE_FTL_NATIVE_CALL_INLINING 1
> +#endif // PLATFORM(EFL)

Please change this to be dependent on COMPILER(CLANG) instead of PLATFORM(EFL) since that is the true nature of the dependency.  You could disable it for !COMPILER(CLANG) || PLATFORM(EFL) if you also don’t want to use it for EFL regardless of the compiler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.