[Webkit-unassigned] [Bug 135560] [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135560





--- Comment #5 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-08-05 22:49:39 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 235971 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=235971&action=review
> > 
> > > Source/WebCore/ChangeLog:10
> > > +        * PlatformEfl.cmake:
> > 
> > > ChangeLog:8
> > > +        * Source/cmake/OptionsEfl.cmake:
> > 
> > We need to mention what you do this file.
> 
> I'll add descriptions to the modified files, thanks for pointing it out.
> 
> > It would be nice if you write what is changed in each file.
> > 
> > > Tools/Scripts/webkitperl/FeatureList.pm:-398
> > > -      define => "WTF_USE_TILED_BACKING_STORE", default => isEfl(), value => \$tiledBackingStoreSupport },
> > 
> > USE(TILED_BACKING_STORE) is still being used in source code. So, I'm not sure whether we can remove this here.
> 
> If we leave it in the code, the build will fail in case of minimal build. None of the other ports use it, so it's safe to remove it.

If so, you can just change isEfl() with 0. Are you sure whether other ports never enable it again ?

> > > -      define => "WTF_USE_TILED_BACKING_STORE", default => 0, value => \$tiledBackingStoreSupport },

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.