[Webkit-unassigned] [Bug 135625] Add the ability to force text to render in white, not just black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135625


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236057|review?                     |review+
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-08-05 15:52:58 PST ---
(From update of attachment 236057)
View in context: https://bugs.webkit.org/attachment.cgi?id=236057&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:631
> +    const ShadowData* textShadow = (paintInfo.forceTextColor()) ? 0 : lineStyle.textShadow();

0 -> nullptr

> Source/WebCore/rendering/PaintPhase.h:63
> +    PaintBehaviorForceWhiteText = 1 << 6,

Please put this under PaintBehaviorForceBlackText and change the numbers.

> Source/WebCore/rendering/TextPaintStyle.cpp:142
> +        const ShadowData* shadow = paintInfo.forceTextColor() ? 0 : pseudoStyle->textShadow();

0 -> nullptr

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.