[Webkit-unassigned] [Bug 135358] [ftlopt] Create a more generic way for VMEntryScope to notify those interested that it will be destroyed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135358


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #235714|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #15 from Geoffrey Garen <ggaren at apple.com>  2014-08-04 14:58:14 PST ---
(From update of attachment 235714)
View in context: https://bugs.webkit.org/attachment.cgi?id=235714&action=review

r=me

> Source/JavaScriptCore/debugger/Debugger.cpp:342
> +            Debugger* debugger = globalObject->debugger();
> +            if (debugger)
> +                debugger->recompileAllJSFunctions(vm);

It's nice to write this as a single line. That way, it's lexically impossible to use the NULL pointer:

if (Debugger* debugger = globalObject->debugger()) { ... }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.