[Webkit-unassigned] [Bug 135515] Create stub long mouse press controller. Part of 135257 - Add long mouse press gesture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135515





--- Comment #3 from Peyton Randolph <prandolph at apple.com>  2014-08-01 15:31:05 PST ---
(In reply to comment #2)
> (From update of attachment 235894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235894&action=review
> 
> > Source/WebCore/page/ChromeClient.h:198
> > +    virtual void startLongMousePress(const IntPoint&) const = 0;
> 
> This should be didStartLongMousePress, right?

I'll rename these methods to be in the past tense.

> 
> > Source/WebCore/page/ChromeClient.h:199
> > +    virtual void triggerLongMousePress() const = 0;
> 
> triggered?

Ditto.
> 
> > Source/WebCore/page/ChromeClient.h:200
> > +    virtual void cancelLongMousePress() const = 0;
> 
> didCancel?

Ditto.

> 
> > Source/WebKit2/Shared/LongMousePressData.h:48
> > +    String urlString;
> 
> Can this be a URL?

I think so. But similar structures like InteractionInformationAtPosition and every WebPageProxy message represent URLs as Strings. I don't know why, so I'll tentatively leave this as String.

> 
> > Source/WebKit2/WebProcess/WebPage/LongMousePressController.h:50
> > +    __unused WebPage* m_webPage;
> 
> Weird.

Removed member variable. I'll add it back when it's used in a future patch.
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1176
> > +    LongMousePressController m_longMousePressController;
> 
> Can we store in a unique_pointer and only allocate when we need one?

Done.

(In reply to comment #2)
> (From update of attachment 235894 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235894&action=review
> 
> > Source/WebCore/page/ChromeClient.h:198
> > +    virtual void startLongMousePress(const IntPoint&) const = 0;
> 
> This should be didStartLongMousePress, right?
> 
> > Source/WebCore/page/ChromeClient.h:199
> > +    virtual void triggerLongMousePress() const = 0;
> 
> triggered?
> 
> > Source/WebCore/page/ChromeClient.h:200
> > +    virtual void cancelLongMousePress() const = 0;
> 
> didCancel?
> 
> > Source/WebKit2/Shared/LongMousePressData.h:48
> > +    String urlString;
> 
> Can this be a URL?
> 
> > Source/WebKit2/WebProcess/WebPage/LongMousePressController.h:50
> > +    __unused WebPage* m_webPage;
> 
> Weird.
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.h:1176
> > +    LongMousePressController m_longMousePressController;
> 
> Can we store in a unique_pointer and only allocate when we need one?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.