[Webkit-unassigned] [Bug 135434] Hit-testing broken in WebKit 1 views with AppKit's contentInsets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135434





--- Comment #15 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-08-01 12:02:15 PST ---
(From update of attachment 235847)
View in context: https://bugs.webkit.org/attachment.cgi?id=235847&action=review

> Source/WebCore/page/FrameView.h:393
> -    IntRect convertFromRenderer(const RenderElement*, const IntRect&) const;
> -    IntRect convertToRenderer(const RenderElement*, const IntRect&) const;
> -    IntPoint convertFromRenderer(const RenderElement*, const IntPoint&) const;
> -    IntPoint convertToRenderer(const RenderElement*, const IntPoint&) const;
> +    IntRect convertFromRendererToContainingView(const RenderElement*, const IntRect&) const;
> +    IntRect convertFromContainingViewToRenderer(const RenderElement*, const IntRect&) const;
> +    IntPoint convertFromRendererToContainingView(const RenderElement*, const IntPoint&) const;
> +    IntPoint convertFromContainingViewToRenderer(const RenderElement*, const IntPoint&) const;

I think this rename adds ambiguity: it's no longer clear whether it's converting to This view or This view's containing view.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.