[Webkit-unassigned] [Bug 132287] New: Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_SECURITY_IMPLICATION

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132287

           Summary: Build failure in RenderFlowThread.cpp when building
                    release with ASSERT_WITH_SECURITY_IMPLICATION
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ayao at apple.com


When building a release build of WebKit with ASSERT_WITH_SECURITY_IMPLICATION enabled, I'm getting a build error

/Volumes/data_apps/WebKit/Source/WebCore/rendering/RenderFlowThread.cpp:606:38: error: use of undeclared
      identifier 'checkLinesConsistency'
    ASSERT_WITH_SECURITY_IMPLICATION(checkLinesConsistency(blockFlow));

http://trac.webkit.org/changeset/167871
added the assert.

In RenderFlowThread.cpp, RenderFlowThread::checkLinesConsistency and other functions are defined inside a #ifndef NDEBUG.

Instead, it should be 
#if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED 

By default, the behavior will be the same, but this will fix the build for release + ASSERT_WITH_SECURITY_IMPLICATION.

See http://trac.webkit.org/changeset/160462 for an example of a similar change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.