[Webkit-unassigned] [Bug 132403] Always-visible scrollbars continuously repaint after non-momentum scrollling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132403


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230522|review?                     |review+
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-04-30 14:47:04 PST ---
(From update of attachment 230522)
View in context: https://bugs.webkit.org/attachment.cgi?id=230522&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:143
> +        if (m_verticalScrollbarPainter)
> +            [m_verticalScrollbarPainter setUsePresentationValue:YES];
> +        if (m_horizontalScrollbarPainter)
> +            [m_horizontalScrollbarPainter setUsePresentationValue:YES];

You don't really need the nil checks (messaging nil is OK).

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:378
> +        if (m_verticalScrollbarPainter && [m_verticalScrollbarPainter shouldUsePresentationValue]) {

Could just be if ([m_verticalScrollbarPainter shouldUsePresentationValue])

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:385
> +        if (m_horizontalScrollbarPainter && [m_horizontalScrollbarPainter shouldUsePresentationValue]) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.