[Webkit-unassigned] [Bug 132372] Phone number data detection UI is offset for iframes, pages with topContentInset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132372





--- Comment #5 from Beth Dakin <bdakin at apple.com>  2014-04-29 21:31:34 PST ---
(In reply to comment #4)
> (From update of attachment 230452 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230452&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:77
> > +        IntPoint frameOffset(frame->view()->scrollOffset().width(), frame->view()->scrollOffset().height());
> > +        offset.move(frameOffset.x(), frameOffset.y());
> > +        offset = frame->view()->contentsToRootView(offset);
> 
> contentsToRootView() already subtracts the scrollOffset, so I'm not sure why you have to do it manually here.

Hmm, you're right. This is kind of a hack I guess. The original offset value is not actually a contents point because it already factors in the scroll position, so I was factoring it out only to get contentsToRootView() to work correctly and factor it back in.

Using Widget::convertToRootView() does the right thing for frames and subframes, but that leaves overflow areas broken. 

I'm torn about defending the hack vs. finding a better solution. Will think on this a bit more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.