[Webkit-unassigned] [Bug 130891] [CSS Blending] Blending doesn't work if the parent stacking context is a normal flow only element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130891





--- Comment #9 from Ion Rosca <rosca at adobe.com>  2014-04-29 14:34:34 PST ---
(From update of attachment 230376)
View in context: https://bugs.webkit.org/attachment.cgi?id=230376&action=review

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:1108
>>      layer.updateDescendantDependentFlags();
> 
> Can layer.updateIsolationForBlendingDescendantsIfNeeded() be rolled into layer.updateDescendantDependentFlags()? That would avoid adding an extra child walk.

Done. I had to change some code for the other flags, but not the logic.

>> Source/WebCore/rendering/RenderLayerModelObject.cpp:157
>> +#endif
> 
> Can't we do this in RenderLayer::styleChanged()?

On this branch RenderLayer is going to be removed for this RenderObject and RenderLayer::styleChanged will never get called.

>> LayoutTests/ChangeLog:19
>> +        * css3/compositing/blend-mode-isolation-turn-on-self-painting-layer.html: Added.
> 
> Can we make these ref tests please?

It's hard to make ref tests for blending. There is a bug regarding wrong color results: https://bugs.webkit.org/show_bug.cgi?id=130582 and we don't really know what colors to expect. The blending output colors have slightly diferrent  on retina vs non retina displays and among OS versions. I think layer tree is the more appropriate way to test isolation, because isolation flag is also dumped in RenderTreeAsText.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.