[Webkit-unassigned] [Bug 132222] Don't snapshot plugins that are overlaid with images.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132222


Jon Lee <jonlee at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230351|review+                     |review?
               Flag|                            |




--- Comment #8 from Jon Lee <jonlee at apple.com>  2014-04-29 09:30:21 PST ---
(From update of attachment 230351)
View in context: https://bugs.webkit.org/attachment.cgi?id=230351&action=review

It would be nice to include some logging so that it is easy to see what’s happening if we turn the channel on.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4388
> +            

Please remove the extraneous whitespace sprinkled throughout this patch.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4401
> +            inflatedPluginRect.setY(inflatedPluginRect.y() - yOffset);

Isn’t this what inflate() is for?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.