[Webkit-unassigned] [Bug 132330] LLINT loadisFromInstruction doesn't need special case for big endians

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132330


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230365|review?                     |review-
               Flag|                            |




--- Comment #2 from Mark Lam <mark.lam at apple.com>  2014-04-29 06:10:08 PST ---
(From update of attachment 230365)
View in context: https://bugs.webkit.org/attachment.cgi?id=230365&action=review

Thanks for fixing this.  If you update the ChangeLog comment, we should be good to go.

> Source/JavaScriptCore/ChangeLog:9
> +        The change introduced in r167076 was wrong. We cannot apply the offset
> +        adjustment on every loadisFromInstruction usage as the instruction

Please change “cannot” to “should not” and remove “every”.  As it read previously, it implied that there are some cases where the offset should be applied, which is not true.  It is always wrong to applied that offset.

> Source/JavaScriptCore/ChangeLog:11
> +        operand variable). The offset of the union members will be the

Please change “union” to “other union”.

> Source/JavaScriptCore/ChangeLog:13
> +        same on little and big endian architectures thus we don't need

Missing period between “architectures. Thus”.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.