[Webkit-unassigned] [Bug 132294] New: Don't immediately snapshot plugin to allow for proper dominant plugin detection.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132294

           Summary: Don't immediately snapshot plugin to allow for proper
                    dominant plugin detection.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: roger_fong at apple.com
                CC: dino at apple.com, webkit-bug-importer at group.apple.com,
                    roger_fong at apple.com


Currently we immediately set the display state to displaying snapshot if the max number of snapshot retries is 0.
However, this causes timing problems. Namely, it causes hit testing to fail because the hit test needs to happen with the original plugin element.
If we instead call beginSnapshottingRunningPlugin, we allow the page some time to perform the hit test with the plugin element before snapshotting.

I've only seen this affect layout tests, where we explicitly set the max number of snapshot retries to 0.
This fix will allow us to enable snapshotting tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.