[Webkit-unassigned] [Bug 132222] Don't snapshot plugins that are overlaid with images.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 27 20:33:51 PDT 2014


--- Comment #4 from Jon Lee <jonlee at apple.com>  2014-04-27 20:34:13 PST ---
(From update of attachment 230248)
View in context: https://bugs.webkit.org/attachment.cgi?id=230248&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4383
> +            


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4386
> +            


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4394
> +            inflatedPluginRect.scale(overlappingImageBoundsScale);

Is this correct? This scales both the position and size from the corner, not out from the center.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4402
> +                    continue;

I think the check should be reversed to avoid the awkward else clause

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4407
> +            


> LayoutTests/plugins/snapshotting/autoplay-plugin-blocked-by-image.html:13
> +<img src="../resources/apple.gif" width="600" height="600" style="position:relative; top:-600px;">

Can we add some more test cases here to handle images that are within the percentages? What happens with transforms? absolute positioned image? Or taking markup inspired by some of the websites we’ve seen issues with?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list