[Webkit-unassigned] [Bug 131023] [CSS Grid Layout] Clamping the number of repetitions in repeat()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131023


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230164|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2014-04-25 09:57:13 PST ---
(From update of attachment 230164)
View in context: https://bugs.webkit.org/attachment.cgi?id=230164&action=review

This patch seems fine overall. Please make make the MAX_REPETITIONS name more descriptive when you land.

>> Source/WebCore/css/CSSParser.cpp:4930
>> +        repetitions = MAX_REPETITIONS;
> 
> Should there be any kind of feedback to the inspector when this happens?

Also: I think you should reference the specification or draft that specifies this limit, and call the variable "MAX_GRID_TRACK_REPETITIONS".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.