[Webkit-unassigned] [Bug 132180] [GTK] Implement iframe shim technique for windowed plugins in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132180


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230170|review?                     |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2014-04-25 07:38:14 PST ---
(From update of attachment 230170)
View in context: https://bugs.webkit.org/attachment.cgi?id=230170&action=review

GTK+ bits look good to me.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1027
> +static bool iframeIsAbovePlugin(const Vector<const RenderObject*>& iframeZIndexStack, const Vector<const RenderObject*>& pluginZIndexStack)
> +{
> +    for (size_t i = 0; i < iframeZIndexStack.size() && i < pluginZIndexStack.size(); ++i) {
> +        // The root is at the end of these stacks. We want to iterate root-downwards so we index backwards from the end.
> +        const RenderObject* iframeStackRootObject = iframeZIndexStack[iframeZIndexStack.size() - 1 - i];
> +        const RenderObject* pluginStackRootObject = pluginZIndexStack[pluginZIndexStack.size() - 1 - i];

This requires preserving the original copyright, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.