[Webkit-unassigned] [Bug 132090] Web Inspector: CSS autofill suggests properties instead of values when values are needed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 24 17:00:52 PDT 2014


--- Comment #8 from Timothy Hatcher <timothy at apple.com>  2014-04-24 17:01:13 PST ---
(From update of attachment 230108)
View in context: https://bugs.webkit.org/attachment.cgi?id=230108&action=review

> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:523
> +        if (!mainToken.state || !mainToken.state.state || !mainToken.state.state === "block")
>              return [];

This is not right. The while loop later looks for "prop", but this returns early if there is no "block" state. This needs to do a similar contains check up the state stack for "block".

As-is only proper name completions will work, property value completions will not work. But maybe you intended to fix this in the other bug.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list