[Webkit-unassigned] [Bug 132090] Web Inspector: CSS autofill suggests properties instead of values when values are needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132090


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230108|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org>  2014-04-24 14:59:30 PST ---
(From update of attachment 230108)
View in context: https://bugs.webkit.org/attachment.cgi?id=230108&action=review

r=me

> Source/WebInspectorUI/ChangeLog:13
> +        data structure. All references to state.stack are obscelete. Many

Typo: obscelete

> Source/WebInspectorUI/ChangeLog:884
> -        Add missing semicolon.        
> +        Add missing semicolon.

I wonder if commit queue will allow a patch that fixes this trailing whitespace. Maybe it will, maybe it won't.

> Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js:398
> +        if (!state.stack || !state.stack.length || state.stack.lastValue === "@media{")

These only fix the exception, but I assume they don't make CSS pretty printing work?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.