[Webkit-unassigned] [Bug 132017] DocumentLoader::dataReceived assertion failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132017


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #230005|review?                     |review+
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2014-04-23 16:29:40 PST ---
(From update of attachment 230005)
View in context: https://bugs.webkit.org/attachment.cgi?id=230005&action=review

Wow -- uninitialized variables.

Double-check that network tests still pass with this change. That 'didReceiveResponse' might be needed to flush the client state in cases where the response wasn't received earlier...

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-687
> -                d->client()->didReceiveResponse(job, d->m_response);

Its possible that this is needed in addition to the one you added above, to handle cases where the client did not receive a valid/complete response, but WebKit needs to be told to "move to the next state".

Maybe double-check that HTTP and network tests work properly after this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.