[Webkit-unassigned] [Bug 131444] [CSS Shapes] Add support for shape-outside gradient values
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 18 13:55:23 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=131444
--- Comment #8 from Bem Jones-Bey <bjonesbe at adobe.com> 2014-04-18 13:55:42 PST ---
(From update of attachment 229662)
View in context: https://bugs.webkit.org/attachment.cgi?id=229662&action=review
> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:125
> + ASSERT(styleImage);
if this can't be null, why not pass a reference? (even better, can it be a const ref?)
> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:153
> + image = styleImage->image(const_cast<RenderBox*>(&renderBox), imageSize).get();
It would be nice to see a follow-up patch that removes the need for the const_cast here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list