[Webkit-unassigned] [Bug 106819] Mac/Mac-wk2/Win build bots fails to compile if 'CSS3_TEXT' feature flag is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106819





--- Comment #17 from Lamarque V. Souza <lamarque at gmail.com>  2014-04-18 13:00:39 PST ---
(In reply to comment #16)
> (From update of attachment 184995 [details])
> Clearing review flag on this patch, since it's rather old at this point.
> 
> Is this bug actually still valid, or can we close it out?

Shorter answer: it is probably still valid.

Longer answer: I use Linux only and do not have a mac or windows with Webkit installed to debug the problem myself. All changes in patch "Enables css3-text feature flag" were made to make my patches to do not fail with mac and win build bots. All that during several try and error rounds.

The point is that css3-text is disabled by default in the build bots, which means that any patch that uses css3-text is approved by the bots, be they working or not. We (my ex-co-worker and me) did this to force the build bots to really test our patches instead of just approving them right away, which is the correct thing to do in our opinion.

Without such a patch the bots are useless to catch possible regressions in css3-text code.

PS: this patch is not meant to enter Webkit (at least not until css3-text is enabled by default).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.