[Webkit-unassigned] [Bug 131444] [CSS Shapes] Add support for shape-outside gradient values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131444





--- Comment #5 from Bem Jones-Bey <bjonesbe at adobe.com>  2014-04-18 11:54:18 PST ---
(From update of attachment 229578)
View in context: https://bugs.webkit.org/attachment.cgi?id=229578&action=review

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:123
> +static inline bool checkShapeImageOrigin(Document& document, const ShapeValue& shapeValue)

Why take a ShapeValue instead of a StyleImage?

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:128
> +    CachedImage& cachedImage = *(shapeValue.image()->cachedImage());

I'd ASSERT(shapeValue.image()->cachedImage()) first, just to be safe.

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:151
> +        image = styleImage->image(const_cast<RenderBox*>(&renderBox), imageSize).get();

The const_cast makes me very uncomfortable. There isn't a better way to do this? Maybe we need to refactor StyleImage so it can take a const?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.