[Webkit-unassigned] [Bug 131515] Inlining native functions into the JavaScript in the FTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131515





--- Comment #15 from Matthew Mirman <mmirman at apple.com>  2014-04-17 16:41:09 PST ---
(In reply to comment #14)
> (From update of attachment 229589 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=229589&action=review
> 
> Have you done performance measurements?  Have you run-javascriptcore-tests?  Have you run-webkit-tests?
> 
> > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3512
> > +                if (++instructionCount >= 275)
> 
> You should turn 275 into an Options::maximumLLVMInstructionCountForNativeInlining().  See runtime/Options.h.  Add a new option there and make 275 the default.
> 
> Where does 275 come from?

275 is the default for LLVM's inlining threshold. I have absolutely no idea how they actually compare, or how LLVM gets the number to compare to its 275.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.