[Webkit-unassigned] [Bug 131784] [Win] A few final cleanups to the DataObject classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131784


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |bfulgham at webkit.org
                   |kit.org                     |
 Attachment #229517|                            |review?
               Flag|                            |
                 CC|                            |bfulgham at webkit.org,
                   |                            |darin at apple.com




--- Comment #1 from Brent Fulgham <bfulgham at webkit.org>  2014-04-16 20:26:41 PST ---
Created an attachment (id=229517)
 --> (https://bugs.webkit.org/attachment.cgi?id=229517&action=review)
Patch

--- Comment #2 from Darin Adler <darin at apple.com>  2014-04-17 10:29:26 PST ---
(From update of attachment 229517)
View in context: https://bugs.webkit.org/attachment.cgi?id=229517&action=review

> Source/WebCore/platform/win/WCDataObject.cpp:361
> +            m_formats[ptr] = std::move(m_formats.last());
>              m_formats.removeLast();

Should be takeLast, not last/removeLast.

> Source/WebCore/platform/win/WCDataObject.cpp:363
> +            m_medium[ptr] = std::move(m_medium.last());
>              m_medium.removeLast();

Should be takeLast, not last/removeLast.

> Tools/DumpRenderTree/win/DRTDataObject.cpp:350
> +            m_formats[position] = std::move(m_formats.last());
>              m_formats.removeLast();

Should be takeLast, not last/removeLast.

> Tools/DumpRenderTree/win/DRTDataObject.cpp:352
> +            m_medium[position] = std::move(m_medium.last());
>              m_medium.removeLast();

Should be takeLast, not last/removeLast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.