[Webkit-unassigned] [Bug 130891] [CSS Blending] Blending doesn't work if the parent stacking context is a normal flow only element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130891





--- Comment #4 from Mihnea Ovidenie <mihnea at adobe.com>  2014-04-17 04:00:38 PST ---
(From update of attachment 228828)
View in context: https://bugs.webkit.org/attachment.cgi?id=228828&action=review

> Source/WebCore/ChangeLog:11
> +        The stacking context layers having unisolated blending descendants should be able to create

I guess you are referring to stacking content layers in normal flow here.

> Source/WebCore/ChangeLog:21
> +        There is another affected flag for ancestors (A) of the isolating stacking context layer S:

What is this comment about?

> Source/WebCore/ChangeLog:29
> +        (WebCore::RenderLayer::updateDescendantDependentFlags): turning off the isSelfPaintgLayer flag.

isSelfPaintgLayer -> isSelfPaintingLayer

> LayoutTests/ChangeLog:3
> +        [CSS Blending] Blending doesn't work if the parent stacking context is a normal flow only element

I would like to see tests in which this behaviour- transitioning between normal flow only and self painting layer - is dynamically tested. For the layout tests, please make sure you have the right indentation.

> LayoutTests/css3/compositing/blend-mode-accelerated-parent-overflow-hidden-transparent.html:13
> +		margin-left: 10px;

Why do you need this?

> LayoutTests/css3/compositing/blend-mode-accelerated-parent-overflow-hidden-transparent.html:26
> +<p>This test checks that accelerated blending has no effect when the backdrop is a transparent normal flow only layer.</p>

Please add a line here in which you describe what success looks like when you run the test manually. For instance:
<p>On success you should see a green rectangle below.</p>

> LayoutTests/css3/compositing/blend-mode-parent-overflow-hidden.html:22
> +<p>This test checks that software blending has no effect when the backdrop is a transparent normal flow only layer.</p>

Same as above, please add a note about how success looks like when you manually load this test into a browser.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.