[Webkit-unassigned] [Bug 131734] [EFL][WK1] SSL Strict is set according to input parameter.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 16:20:03 PDT 2014


--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-04-16 16:20:22 PST ---
(From update of attachment 229445)
View in context: https://bugs.webkit.org/attachment.cgi?id=229445&action=review

> Source/WebKit/efl/ChangeLog:10
> +        Otherwise, SSLStrict is unset.

Unneeded line break.

> Source/WebKit/efl/ewk/ewk_network.cpp:56
>  void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates)

BTW, parameter name is different with public header. Public header has used *enable*

EAPI void ewk_network_tls_certificate_check_set(Eina_Bool enable);

> Source/WebKit/efl/ewk/ewk_network.cpp:58
>      unsigned policy = WebCore::SoupNetworkSession::defaultSession().sslPolicy();

Now I understand this API behavior is to enable soup SSL policy if checkCertificates is enabled. However, it looks this API is getting current ssl policy value unnecessary because you set *policy* value only depends on *checkCertificates*. I think there are two choices. One is just to set the policy regardless of current policy value. The other is to enable only both when *checkCertificates* is enabled and *current policy value* is disabled.

Below may be one of examples for first one.

void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates) {
    if (checkCertificates)
        policy = WebCore::SoupNetworkSession::SSLStrict;
        policy = ~WebCore::SoupNetworkSession::SSLStrict;


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list