[Webkit-unassigned] [Bug 124999] [Texmap] TextureMapperLayer unnecessary object copying

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 16 14:08:55 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=124999


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224737|review?                     |review-
               Flag|                            |




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org>  2014-04-16 14:09:15 PST ---
(From update of attachment 224737)
View in context: https://bugs.webkit.org/attachment.cgi?id=224737&action=review

Looks very go! Pleaseo switch to 'auto&', but otherwise this looks good.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:348
> +    for (IntRect& rect : rects) {

Please make this for (auto& rect : rects) {

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:367
> +    for (IntRect& rect : rects) {

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list