[Webkit-unassigned] [Bug 131677] [EFL] Cleanup the build from unused parameters in WebKit-efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131677


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-04-15 20:18:57 PST ---
(In reply to comment #3)
> Gyuyoung, Thank you for your feedback.
> (In reply to comment #2)
> > > Source/WebKit/efl/ewk/ewk_network.cpp:-56
> > > -void ewk_network_tls_certificate_check_set(Eina_Bool checkCertificates)
> > 
> > This isn't to remove only parameter name. This is to remove parameter itself. So, you have to say why you should change function argument.
> 
> I thought rule for removing parameter name is for cases that there is already predefined prototype.
> For instance, parent class has virtual member API with several params but child class which has real implementation doesn't need some of params. Or, some cases depending on Feature Enabled.
> 
> In this case,
> ewk_network_tls_certificate_check_set is  API based on C (I mean there is no dependency) and I thought that it's not necessary any more.
> 
> How do you think?
> Thanks,

ASSERT_UNUSED() is matched a rule to remove unused parameter. However, in ewk_network_tls_certificate_check_set() case, you are changing function behavior. So, ewk_network_tls_certificate_check_set() needs to be handled in new bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.