[Webkit-unassigned] [Bug 130148] [GTK][CMAKE] build-webkit doesn't detect when the build fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130148





--- Comment #5 from Brendan Long <b.long at cablelabs.com>  2014-04-15 16:58:19 PST ---
I looked through CMake's source code since they documentation wasn't very helpful, and when generating the build_command, it has a "ignoreErrors" argument, which is unconditionally set to "true" in all cases where it gets called:

    std::string makecommand = this->Makefile->GetLocalGenerator()
      ->GetGlobalGenerator()->GenerateCMakeBuildCommand(target, configuration,
                                                      "", true);

With the signature:

    std::string cmGlobalGenerator::GenerateCMakeBuildCommand(
      const std::string& target, const std::string& config,
      const std::string& native,
      bool ignoreErrors)

So if we want to remove the "-i", we'll have to do it manually.

This works:

    string(REPLACE "-i" "" COMMAND_LINE_TO_BUILD ${COMMAND_LINE_TO_BUILD})

I'll look at adding some sort of option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.