[Webkit-unassigned] [Bug 130148] [GTK][CMAKE] build-webkit doesn't detect when the build fails
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 15 16:33:43 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=130148
Brendan Long <b.long at cablelabs.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |b.long at cablelabs.com
--- Comment #1 from Brendan Long <b.long at cablelabs.com> 2014-04-15 16:34:04 PST ---
This is really annoying, because it's hard to tell where a build failed. I think I tracked this down to OptionsGTK.cmake:
build_command(COMMAND_LINE_TO_BUILD)
file(WRITE
${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/build.sh
"#!/bin/sh\n"
"${COMMAND_LINE_TO_BUILD} $@"
)
build_command() by default gives you `make -i`, where `-i` is also known as `--ignore-errors`.
See:
http://www.gnu.org/software/make/manual/html_node/Errors.html#Errors
http://www.cmake.org/cmake/help/v3.0/command/build_command.html
I'm not exactly sure how to fix this yet. Maybe just strip "-i" from the COMMAND_LINE_TO_BUILD?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list