[Webkit-unassigned] [Bug 131553] Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 15 16:26:41 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=131553
Tim Horton <thorton at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #229326|review? |review+
Flag| |
--- Comment #18 from Tim Horton <thorton at apple.com> 2014-04-15 16:27:00 PST ---
(From update of attachment 229326)
View in context: https://bugs.webkit.org/attachment.cgi?id=229326&action=review
This is fine with me as long as the behavior is fine with Jon/Dean, but please confirm.
> Source/WebCore/html/HTMLPlugInImageElement.cpp:609
> + int contentWidth = contentRect.width();
> + int contentHeight = contentRect.height();
why the temporaries? they're only used once below.
> Source/WebCore/html/HTMLPlugInImageElement.cpp:646
> + if (!renderer()->isSnapshottedPlugIn()) {
if you move this above the previous block, you can get rid of that check in its condition
> LayoutTests/plugins/snapshotting/set-plugin-size-to-tiny.html:15
> + testRunner.notifyDone()
semicolon
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list