[Webkit-unassigned] [Bug 130657] Link underline thickness should be uniform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130657





--- Comment #31 from Jeongeun Kim <je_julie.kim at samsung.com>  2014-04-15 05:03:11 PST ---
Simon, Thank you for your feedback. 
(In reply to comment #30)
> > Source/WebCore/rendering/RenderObject.cpp:2145
> > +void RenderObject::getTextDecorationColors(int decorations, Color& underline, Color& overline, Color& linethrough, HashMap<int, RenderStyle*>& styleMap, bool quirksMode, bool firstlineStyle)
> 
> This "int" should more strongly typed. Reading this signature, I have no idea what the int represents.
"int" meant "enum TextDecoration". For make it clear, Is it OK if I changed it to <TextDecoration, RenderStyle*>?

> I'm also not sure that we want the cost of filling in a HashMap with every call to this function.
It is not different from getting color for decoration. In order to get colors for decorations, getTextDecorationColors() is used and outputs are filled with colors on current implementation. I just added additional inforamtion, RenderStyle*. 
One RenderObject could have underline and overline at the same time with different RenderStyles. If you look into test case created at the patch, there are several examples.
Please check,
Thanks,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.