[Webkit-unassigned] [Bug 130019] Web Inspector: Consider updating to CodeMirror 4.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 18:12:31 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130019


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229328|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2014-04-14 18:12:49 PST ---
(From update of attachment 229328)
View in context: https://bugs.webkit.org/attachment.cgi?id=229328&action=review

Looking good. Some minor issues. Also need to rebase so the patch can apply on TOT to land.

> Source/WebInspectorUI/ChangeLog:219
>          * Localizations/en.lproj/localizedStrings.js:
>          * UserInterface/Models/DOMNode.js:
>          * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
> -        * UserInterface/Views/Main.css:
> +        * UserInterface/Views/Main.css:
>  
>  2014-03-28  Joseph Pecoraro  <pecoraro at apple.com>
>  

You should revert the edits to the old parts of the ChangeLog.

> Source/WebInspectorUI/Scripts/update-codemirror-resources.rb:-46
> -  mode/less/less.js

Need to remove less.js from Main.html. Not removing it from there will break the Production build. You should also test to make sure combining the resources like Production builds do still works. Especially jsmin.py still works on the new codemirror.js. Define COMBINE_INSPECTOR_RESOURCES=YES while building to trigger this. Or hack copy-user-interface-resources.pl to always do it.

> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:383
> -
> +

This whole file can be reverted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list