[Webkit-unassigned] [Bug 131608] [sh4] SubImmediates can be used in sh4 LLINT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131608


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229272|review?                     |review+
               Flag|                            |




--- Comment #2 from Mark Lam <mark.lam at apple.com>  2014-04-14 13:54:16 PST ---
(From update of attachment 229272)
View in context: https://bugs.webkit.org/attachment.cgi?id=229272&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:747
> +        if SH4
> +            flushcp # Force constant pool flush to avoid "pcrel too far" link error.
> +        end

I'd be concerned if this proliferates.  Ideally, it's be great if the offline backend knows to call flushcp automatically when needed without the LLINT assembly having to explicitly call it like this.  For now, since there's is only this one use of flushcp (i.e. here), I'll let it go.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.