[Webkit-unassigned] [Bug 131586] Keep secondary tile grid for zoomed-out scale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131586





--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-04-14 12:20:52 PST ---
(From update of attachment 229217)
View in context: https://bugs.webkit.org/attachment.cgi?id=229217&action=review

>> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2999
>> +            m_uncommittedChanges |= ChildrenChanged;
> 
> Do we need to do this always? Is it bad if we do?

Yeah, I would prefer that we don't always do this. It will result in extra remote layer tree transaction thrash.

tiledBacking() should have a:
bool contentsScaleChangeRequiresSublayerUpdate(float) or something.

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:135
> +    return tileGrid().scale() * m_deviceScaleFactor;

I hope the scale /= deviceScaleFactor; and this math don't result in floating-point rounding issues that cause us to compare the contentsScale as different somewhere.

> Source/WebCore/platform/graphics/ca/mac/TileGrid.h:-62
> -    typedef unsigned TileValidationPolicyFlags;

Why did you remove this? I prefer strongly typed bitfield types.

> Source/WebCore/platform/graphics/ca/mac/TileGrid.mm:340
> +void TileGrid::revalidateTiles(unsigned validationPolicy)

:(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.