[Webkit-unassigned] [Bug 131553] Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131553





--- Comment #10 from Dean Jackson <dino at apple.com>  2014-04-13 23:22:09 PST ---
(In reply to comment #9)
> > Source/WebCore/html/HTMLPlugInImageElement.cpp:619
> > +    IntSize visibleViewSize = document().frame()->view()->visibleSize();
> > +    float contentArea = contentWidth * contentHeight;
> > +    float visibleArea = visibleViewSize.width() * visibleViewSize.height();
> > +    return isFullPage && (contentArea > visibleArea * sizingFullPageAreaRatioThreshold);
> 
> If we made an area helper function (overloaded for IntSize and LayoutSize) then these four lines could be written in one line like this:
> 
>     return area(renderer.contentBoxRect()) > area(frame.view()->visibleSize()) * sizingFullPageAreaRatioThreshold;
> 

There already is an area() member function on IntSize. We don't have one on LayoutSize. I like the idea of a helper function so here is a patch: http://webkit.org/b/131606

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.