[Webkit-unassigned] [Bug 130657] Link underline thickness should be uniform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 19:07:32 PDT 2014


--- Comment #20 from Jeongeun Kim <je00julie.kim at gmail.com>  2014-04-12 19:07:49 PST ---
(In reply to comment #18)
Drain, Thank you for your feedback and I'll create a new regression test case.

> > Source/WebCore/rendering/InlineTextBox.cpp:1013
> > +        decorationBox = renderer().getTextDecorationColors(decoration, underline, overline, linethrough, true, true);
> I’m not sure it’s right to overwrite the value we got from the first call with the value from the second call. We need test cases to demonstrate this is good behavior.

Actually I think we don't need to call additionally 'getTextDecorationColors' only for firstline.
It's duplicate.
The 6th param is for FirstLine and we can use it like
"renderer().getTextDecorationColors(decoration, underline, overline, linethrough, true, isFirstLine());"
When text positions at the first line, it will take first line style.
Or not, it will take normal style.
So, I'll remove the second call. How do you think?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list