[Webkit-unassigned] [Bug 127835] ASSERTION FAILED: x2 >= x1 in WebCore::RenderObject::drawLineForBoxSide
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 12 12:21:09 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=127835
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #228846|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #9 from Darin Adler <darin at apple.com> 2014-04-12 12:21:28 PST ---
(From update of attachment 228846)
View in context: https://bugs.webkit.org/attachment.cgi?id=228846&action=review
> LayoutTests/ChangeLog:8
> + Test #1: Negative right margin + positive right padding
> + Test #2: Negative left margin + positive left padding
Tests only covert vertical. Should cover horizontal too.
> LayoutTests/ChangeLog:12
> + * fast/css/padding-margin-overlap-expected.txt: Added.
Please make this a reference test instead of a render-tree-dumping test.
> Source/WebCore/platform/graphics/LayoutRect.h:83
> + bool hasPositiveDimensions() const;
Please don’t add this. It’s the same as !isEmpty. If you look at IntSize::isEmpty and LayoutSize::isEmpty you will find that they are checking for positive dimensions, not just non-zero.
> Source/WebCore/rendering/RenderBoxModelObject.cpp:1731
> + if (!outerBorder.rect().hasPositiveDimensions())
> + return;
Should be:
if (outerBorder.rect().isEmpty())
return;
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list