[Webkit-unassigned] [Bug 131508] win64 build fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 11:57:57 PDT 2014


--- Comment #5 from Darin Adler <darin at apple.com>  2014-04-12 11:58:18 PST ---
(From update of attachment 229080)
View in context: https://bugs.webkit.org/attachment.cgi?id=229080&action=review

> Source/JavaScriptCore/assembler/X86Assembler.h:2276
> -            unsigned nopSize = std::min(size, 15UL);
> +            unsigned nopSize = std::min<unsigned>(size, 15UL);

Once we add <unsigned>, then there is no point in having the UL there any more. The L is particularly silly, since it gives us an unsigned long constant for no good reason.

Also, this function won’t work for any sizes that are greater than the maximum unsigned. It probably should either take an argument of type unsigned or work properly for large values of type size_t. Taking a size_t, and malfunctioning, seems like a strange choice.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list