[Webkit-unassigned] [Bug 131532] [sh4] LLINT is broken

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 11 17:51:00 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=131532





--- Comment #6 from Michael Saboff <msaboff at apple.com>  2014-04-11 17:51:21 PST ---
(From update of attachment 229134)
View in context: https://bugs.webkit.org/attachment.cgi?id=229134&action=review

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:721
> +        mova _relativePCBase, t0
> +        move t0, pcBase

Why can't you just mova _relativePCBase directly into pcBase?

> Source/JavaScriptCore/offlineasm/sh4.rb:1032
> +            $asm.puts ".balign 4"

If the .balign has to fill, is the '0' fill going to be a nop?  You may want to explicitly mention that with a comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list